fix some clippy warnings

src/route.rs

@@ -141,12 +141,14 @@ fn base<'a>(
         )
     ];
 
+    #[allow(clippy::needless_collect)]
+    // the collect is necessary to end the borrow of borrows default_links by the map closure
     let links = config
         .config
         .footer_links
         .iter()
         .map(|elem| {
-            default_links.retain(|&(title, _)| title != &elem.title);
+            default_links.retain(|&(title, _)| title != elem.title);
             (elem.title.as_str(), elem.url.as_deref())
         })
         .collect::<Vec<_>>();

src/route/job_offer.rs

@@ -20,7 +20,7 @@ use crate::job_offers::JobOffers;
 use crate::route::job_offer::error::SyncError;
 use crate::route::{HTML_CONTENT, JSON_CONTENT};
 use crate::server_config::ServerConfig;
-use crate::{auth, template};
+use crate::template;
 
 pub fn configure(service: &mut ServiceConfig) {
     service

src/route/job_offer/create.rs

@@ -67,17 +67,20 @@ pub(crate) async fn create_joboffer_post(
 
     debug!("getting lease for new submission");
     let submission_lease = {
-        let con_inf = req.connection_info();
+        let ip = {
             // we expect to be run behind a reverse proxy so we can trust the Forwarded/X-Forwarded-For header if they are set
-        let forwarded_for = con_inf
+            let con_inf = req.connection_info();
+
+            let forwarded_for = {
+                con_inf
                     .realip_remote_addr()
-            .expect("should be able to determine a remote address");
-        limiter
-            .into_inner()
-            .get_submission_lease(
-                IpAddr::from_str(forwarded_for).expect("remote address is a valid ip address"),
-            )
-            .await
+                    .expect("should be able to determine a remote address")
+            };
+
+            IpAddr::from_str(forwarded_for).expect("remote address should be a valid ip address")
+        };
+
+        limiter.into_inner().get_submission_lease(ip).await
     };
 
     if submission_lease.is_none() && user.is_none() {